Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scully): adding support for project.json with no angular.json or workspace.json #1654

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sonicparke
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

Currently, individual project.json files in each app are supported but scully still looks for the project path in either workspace.json or angualr.json and expects the projects object to exist. With the latest versions of Nx all the project configs have been migrated into the app folders and workspace.json & angular.json are removed.

Issue Number: #1520

What is the new behavior?

If there is no projects object in angular.json or workspace.jsonscully will then look for project.json is the apps/[project] folder.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

@navneet10sep navneet10sep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The folder name "apps" in the latest version of NX has been renamed to "packages" when using Package-Based Repositories. It would be better to provide the folder name in the "sully.[project-name].config.ts" file.

@sonicparke
Copy link
Contributor Author

@navneet10sep @SanderElias I've looked at the package-based stuff a little bit and I'm just not clear on how to add an angular app to a package-based nx repo therefore not sure if scully needs to support this.

@SanderElias
Copy link
Contributor

@sonicparke We are working on an entire new schematics. (with we, I mean @Jefiozie and @bampakoa, and me cheering on the sideline ;) )
Perhaps you want to join the conversation? DM me!

@wickstargazer
Copy link

Bump, i tested this it seems to work for me, except for ProjectName which if in another subfolder in 'apps' then i havve to do something like 'apps/frontend'

can we get this merged in? i dont want to use the fork version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants