Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update readme #459

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

docs: Update readme #459

wants to merge 1 commit into from

Conversation

Thegaram
Copy link

@Thegaram Thegaram commented Aug 8, 2023

1. Purpose or design rationale of this PR

Update readme.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • docs: Documentation-only changes

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@Thegaram Thegaram requested a review from icemelon August 8, 2023 13:19

## ZK-Rollup

ZK-Rollup adapts the Go Ethereum to run as Layer 2 Sequencer. The codebase is based on v1.10.13.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can still keep this "The codebase is based on v1.10.13."

Comment on lines -16 to -18
### ZKTrie Storage

Another implement for storage trie, base on patricia merkle tree, has been induced. It is feasible to zk proving in the storage part. It is specified as a flag in gensis, set `config.scroll.useZktrie` to true for enabling it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep and rephrase this part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants