Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sepolia deployment issues #1071

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

0xmountaintop
Copy link

This reverts commit bc6d184.

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@0xmountaintop 0xmountaintop changed the title Revert "cmd/devp2p, eth: drop eth/66 (#28239)" [DON't MERGE] Revert "cmd/devp2p, eth: drop eth/66 (#28239)" Oct 15, 2024
@colinlyguo colinlyguo force-pushed the syncUpstream/rever_drop_eth66 branch 3 times, most recently from 5c1fd89 to 43fe9f3 Compare October 18, 2024 13:11
@colinlyguo colinlyguo force-pushed the syncUpstream/rever_drop_eth66 branch from 43fe9f3 to b92db10 Compare October 18, 2024 13:18
@colinlyguo colinlyguo changed the title [DON't MERGE] Revert "cmd/devp2p, eth: drop eth/66 (#28239)" Revert "cmd/devp2p, eth: drop eth/66 (#28239)" Oct 23, 2024
@colinlyguo colinlyguo changed the title Revert "cmd/devp2p, eth: drop eth/66 (#28239)" fix sepolia deployment issues Oct 23, 2024
@colinlyguo colinlyguo merged commit 3e138a9 into syncUpstream/active Oct 23, 2024
5 of 6 checks passed
@colinlyguo colinlyguo deleted the syncUpstream/rever_drop_eth66 branch October 23, 2024 08:48
@colinlyguo colinlyguo changed the title fix sepolia deployment issues fix: sepolia deployment issues Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants