Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboards Update #348

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Keyboards Update #348

merged 1 commit into from
Aug 10, 2023

Conversation

nyfz18
Copy link
Contributor

@nyfz18 nyfz18 commented Jul 30, 2023

Contributor checklist


Description

Add keyboards for French, Italian, Portuguese, Russian, Spanish, Swedish for the expanded version of the iPad and the symbols for those keyboards.

Related issue

French, Italian, Portuguese, Russian, Spanish, Swedish
@github-actions
Copy link

github-actions bot commented Jul 30, 2023

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@andrewtavis andrewtavis self-requested a review July 30, 2023 15:58
@andrewtavis
Copy link
Member

No conflict for this, @nyfz18! I'll try to get to it soon :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really good, @nyfz18! I'll have a few changes to send along, but this is super helpful 😊 Sorry this took a little bit! Was on a bit of a workcation and needed to take some days to unwind from all the work after work :)

Will write in the issue after the commit I'll make!

@andrewtavis andrewtavis merged commit 3c16cef into scribe-org:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants