Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented and ignored number key row for ipad. #295

Merged
merged 1 commit into from
Apr 22, 2023

Conversation

neisenlo
Copy link
Contributor

@neisenlo neisenlo commented Apr 21, 2023

Contributor checklist

  • This pull request is on a separate branch and not the main branch
  • I have updated the CHANGELOG with a description of my changes for the upcoming release (if necessary)

Description

Related issue

@andrewtavis andrewtavis self-assigned this Apr 21, 2023
@andrewtavis
Copy link
Member

Thanks, @neisenlo! I’ll check this later on 😊 Appreciate your interest in the project and willingness to experiment :)

@andrewtavis andrewtavis removed their assignment Apr 21, 2023
@andrewtavis andrewtavis self-requested a review April 21, 2023 18:07
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, @neisenlo! Thanks also for adding in the comments for characters that will need to be added to rightKeyChar 😊 Minor minor thing in regards to comments is that we're following a style where if they're on their own line then they're a complete sentence including punctuation and capitalization, and if they're inline then no capitalization or periods :) No stress! Just for the next one!

@andrewtavis andrewtavis merged commit cceb80e into scribe-org:main Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants