-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix polling order in contrib modules #349
Conversation
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
==========================================
+ Coverage 68.37% 69.45% +1.08%
==========================================
Files 17 20 +3
Lines 860 920 +60
Branches 104 115 +11
==========================================
+ Hits 588 639 +51
- Misses 242 246 +4
- Partials 30 35 +5
Continue to review full report at Codecov.
|
@Digenis |
I was busy, I'll review it in a day or two |
Any progress? |
if config.getboolean('fix_poll_order', False): | ||
log.msg("Activating contrib modules for fix_poll_order") | ||
poller = FixQueuePoller(config) | ||
else: | ||
poller = QueuePoller(config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should do something similar to Launcher, etc. so that users can select any module (including their own), not just between these two modules.
This looks similar to #344 except is puts the new logic in a contrib module, and users opt-in to using that module. As mentioned there, this multi-queue prioritization approach seems more complicated than a single queue, discussed in #187. I've now made the |
This PR use project_priority_map to store (priority, -timestamp) as value,
so as to respect both job priorities across projects and the FIFO principle.
See also issue #187 and PR #344.