Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add regression tests #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions shublang/shublang.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ def sanitize(iterable):
# TODO change name and add other options

iterable = (x.strip() for x in iterable)
iterable = (x for x in iterable if x)
iterable = (re.sub(r'[\n\t\r\s]+', ' ', x) for x in iterable)
iterable = (x.encode('ascii', errors='ignore').decode('ascii') for x in iterable)
iterable = (replace_entities(x) for x in iterable)
Expand Down
14 changes: 14 additions & 0 deletions tests/test_regression.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
"""This serves as a test bed for using shublang in complex real-world scenarios.
"""

from shublang import evaluate


def test_get_non_empty_price():
data = [' \r\t \n ', '\n', '\n', ' \tprice: $123,823.00 \n', ' ']
expression = 'sanitize | sub("[\$,]", "")'

data = evaluate(expression, data)
assert data == ['price: 123823.00']

assert evaluate('re_search("(\d+\.\d{2})") | first | float | first', data) == 123823.00