Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved footer #1163

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

improved footer #1163

wants to merge 2 commits into from

Conversation

YadlaMani
Copy link

No description provided.

@YadlaMani
Copy link
Author

Closes #1163
@scraly

@scraly
Copy link
Owner

scraly commented Oct 8, 2024

Hi, thanks for the PR

I have a remark:
I tested it and without the underline for a link, people don't know that a word is in fact a link.

@YadlaMani
Copy link
Author

Will add the underline

@YadlaMani
Copy link
Author

@scraly fixed it added underline again

@scraly
Copy link
Owner

scraly commented Oct 15, 2024

Thanks, with the underline it's better :)

is it possible to test an improvement with all the links in a line?

@@ -0,0 +1,6 @@
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YadlaMani I guess there should be no change related to package lock file. Will you revert it.

@scraly
Copy link
Owner

scraly commented Nov 26, 2024

You're right, the website needs a new and improved footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants