Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restructure package to match score-compose layout #74

Merged
merged 7 commits into from
Oct 28, 2024

Conversation

astromechza
Copy link
Member

We've received some feedback that the score-k8s layout is confusing when comparing it to the other score-compose reference example and that it would be easier to understand if it were layed out more similarly.

This PR does some of this migration and clean up. No impact to the runtime is expected.

  1. Setup internal/command package with the cobra commands
  2. Move the main.go to cmd/score-k8s/main.go
  3. Move some images and create the empty docs directory

Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, more consistency with score-compose repo, love it!

Copy link

@delca85 delca85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@astromechza astromechza merged commit d518c3b into main Oct 28, 2024
4 checks passed
@astromechza astromechza deleted the restructure branch October 28, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants