Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto npm publish action and master update #178

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

chadhutchins182
Copy link

This is basically PR #161 but I added the requested feature of only working when a tag is made. This PR used the original PR's branch, but then I updated that branch from current master.

I'm not able to do a end-to-end test with this but I use this same methodology in my project.

In the .yml in this request, I added but commented it out if you wanted to restrict it to just the master branch based on this

@chadhutchins182
Copy link
Author

I think there is an issue with the postinstall.js; as I've been trying to install this in a local registry for a project. I don't know much about what this is doing though.

96 verbose stack Error: [email protected] postinstall: `npm i --prefix ./projects/ngx-mqtt; npm-install-peers`
96 verbose stack Exit status 1
96 verbose stack     at EventEmitter.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\index.js:332:16)
96 verbose stack     at EventEmitter.emit (events.js:315:20)
96 verbose stack     at ChildProcess.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\npm-lifecycle\lib\spawn.js:55:14)
96 verbose stack     at ChildProcess.emit (events.js:315:20)
96 verbose stack     at maybeClose (internal/child_process.js:1021:16)
96 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)
97 verbose pkgid [email protected]
98 verbose cwd C:\Users\chad\Documents\piclock2\piclock
99 verbose Windows_NT 10.0.19042
100 verbose argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "i" "ngx-mqtt"
101 verbose node v12.18.3
102 verbose npm  v6.14.6
103 error code ELIFECYCLE
104 error errno 1
105 error [email protected] postinstall: `npm i --prefix ./projects/ngx-mqtt; npm-install-peers`
105 error Exit status 1
106 error Failed at the [email protected] postinstall script.
106 error This is probably not a problem with npm. There is likely additional logging output above.
107 verbose exit [ 1, true ]

@sclausen
Copy link
Owner

Strange, that you’re not getting any error output besides the existence of an error in that file 🤔

@sclausen sclausen force-pushed the master branch 3 times, most recently from 8d4bd4a to c8e81b0 Compare June 6, 2021 21:25
@chadhutchins182
Copy link
Author

@sclausen I updated this pr with your recent changes and the postinstall.js issue I saw above doesn't seem to be a problem.

It looks like travis-ci failed due to docker secrets; will probably work for you if you have those set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants