-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparse KDE #221
Closed
GardevoirX
wants to merge
17
commits into
scikit-learn-contrib:sparse-kde
from
GardevoirX:sparse-kde
Closed
Sparse KDE #221
GardevoirX
wants to merge
17
commits into
scikit-learn-contrib:sparse-kde
from
GardevoirX:sparse-kde
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces SparseKDE:
SparseKDE
is located atsrc/skmatter/utils/_sparsekde.py
. It mitigates the high cost of doing KDE for large datasets by doing KDE for selected data points (e.g. grid points sampled by farthest point-sampling). This class takes the original dataset as a parameter and fits the model using the sampled grid points.SparseKDE
stored insrc/skmatter/utils/_sparsekde.py
.pairwise_euclidean_distances
andpairwise_mahalanobis_distances
, are realized and stored insrc/skmatter/metrics/pairwise.py
.SparseKDE
and some auxiliary functions are stored intests/test_neighbors.py
. Tests for distance metrics are stored intests/test_metrics.py
.I am not sure if the current API of
SparseKDE
is OK and if the auxiliary classes should be integrated intoSparseKDE
. Also,SparseKDE
seems to be too large and complex. Perhaps it needs to be decomposed into smaller parts, but I have not figured out how.Contributor (creator of PR) checklist
For Reviewer
📚 Documentation preview 📚: https://scikit-matter--221.org.readthedocs.build/en/221/