Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 Adds collection sorting by publication and creation date #671

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

sjproctor
Copy link
Contributor

Story

This commit adds collection search options for sorting by ascending and descending publication dates and ascending and descending creation dates to the dropdown menu.

Ref:

Expected Behavior Before Changes

There was no options to sort collections by publication date or creation date.

Expected Behavior After Changes

The dropdown menu to filter searches now contains four new options: date created (asc), date created (desc), date published (asc), date published (desc). The new filter options work as expected to return search results that match the criteria as the top results.

Screenshots / Video

Drop Down Menu

Screenshot 2024-07-30 at 10 11 03 AM

Functionality

Screen.Recording.2024-07-30.at.10.13.33.AM.mov

This commit adds collection search options for sorting by ascending and descending publication dates and ascending and descending creation dates to the dropdown menu.

Ref:
- #650
@sjproctor sjproctor requested review from kirkkwang and laritakr and removed request for kirkkwang July 30, 2024 18:31
Copy link
Contributor

@laritakr laritakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this WILL require a reindex? Probably important to add a note of that.

@sjproctor sjproctor merged commit cffe715 into main Jul 30, 2024
7 checks passed
@sjproctor sjproctor deleted the i650-sort-collection-by-publication-and-creation branch July 30, 2024 20:21
@kirkkwang
Copy link
Contributor

@laritakr Yeah it does, I added it to the issue itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants