🐛 Work through fallback of rodeo URLs #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces raising exceptions when we can't derive the URL. Instead it opts to return nil and let the caller determine what to do. The primary result is that it's easier to have a rodeo configuration "miss" finding files in the pre-process location due to configuration issues. But alas, that's the nature of a rodeo. Related to: - #294
laritakr
approved these changes
Nov 29, 2023
jeremyf
added a commit
to scientist-softserv/adventist-dl
that referenced
this pull request
Nov 29, 2023
jeremyf
added a commit
to scientist-softserv/adventist-dl
that referenced
this pull request
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces raising exceptions when we can't derive the URL. Instead it opts to return nil and let the caller determine what to do.
The primary result is that it's easier to have a rodeo configuration "miss" finding files in the pre-process location due to configuration issues.
But alas, that's the nature of a rodeo.
Related to: