Ease how we determine preprocessed location #298
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Ease how we determine preprocessed location
8997cf6
Prior to this commit, we assumed the ancestor must have an AARK_ID.
However that is not always the case. Which is confounding given the
data structure of the files; however such is the way of the world.
With this commit we fallback to the file_set's internal information to
attempt to find the file in the preprocessed location. Namely if the
FileSet had an import_url, we'll use that to derive where it probably
went in SpaceStone.
Note: sniffing out where this file exists in SpaceStone is a very
fragile process.
Closes #289
Related to:
🧹 Add .internal_test_app
11a1ae3
Prior to this commit, when we'd push this to CI, we'd continue to
rebuild the
.internal_test_app
; this resulted in 2 hour build times.By adding it to the repository, we explicitly say when we want to
rebuild the internal test application (e.g. by deleting it and letting a
local
bundle exec rake
rebuild it).See the README.md for more details.
🤖 Ignore generated secrets
f50a625
I generated this file by:
brew install ggshield
ggshield secret scan path .internal_test_app --recursive
ggshield secret ignore --last-found
First, to install the Git Guardian
ggshield
. Then to scan the newlycommitted
.internal_test_app
. Finally ignoring the last foundsecrets.