🎁 Service to split previously ingested pdf #292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a new service which combines: - IiifPrint::SplitPdfs::DestroyPdfChildWorksService - IiifPring::Jobs::ChildWorksFromPdfJob Beginning with a PDF fileset, it removes any existing child works (found by either the fileset ID or the title), any pending relationship table entries (found by parent id and fileset ID), and then submits a new job to do the pdf splitting. Note that pending relationship entries will not be removed if they don't have the file_id (which is the id of the fileset that spawned them). This is to avoid removing pending relationships that could still be needed for another fileset on the parent work.
This was referenced Nov 20, 2023
jeremyf
reviewed
Nov 22, 2023
jeremyf
added a commit
that referenced
this pull request
Nov 27, 2023
For applications that have already installed IiifPrint, you'll need to manually add the following to your `config/routes.rb` file: ```ruby mount IiifPrint::Engine, at: '/' ``` Related to: - #292 - #294 Co-authored-by: LaRita Robinson <[email protected]>
jeremyf
added a commit
that referenced
this pull request
Nov 27, 2023
For applications that have already installed IiifPrint, you'll need to manually add the following to your `config/routes.rb` file: ```ruby mount IiifPrint::Engine, at: '/' ``` Related to: - #292 - #294 Co-authored-by: LaRita Robinson <[email protected]>
|
Favor #302 instead. |
jeremyf
added a commit
that referenced
this pull request
Nov 28, 2023
For applications that have already installed IiifPrint, you'll need to manually add the following to your `config/routes.rb` file: ```ruby mount IiifPrint::Engine, at: '/' ``` Related to: - #292 - #294 Co-authored-by: LaRita Robinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is currently an untested WIP but is based on two known working pieces.
Story
This creates a new service which combines:
Beginning with a PDF fileset, it removes any existing child works (found by either the fileset ID or the title), any pending relationship table entries (found by parent id and fileset ID), and then submits a new job to do the pdf splitting.
Note that pending relationship entries will not be removed if they don't have the file_id (which is the id of the fileset that spawned them). This is to avoid removing pending relationships that could still be needed for another fileset on the parent work.
Ref #294