I206 questioning authorities #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will add rights_statements and licenses to spec fixtures and adds a rake task to move them into the internal test app so they can be used for specs.
This commit will enable rights_statement and license to render the term and not the URI.
It seems unnecessary to have all the authorities. This commit removes everything except for the ones used in the test.
Prior to this commit, the jobs:test:setup_db_cmd only ran the engine_cart:generate command. This commit will add a custom task that runs generate and copies over the authorities before specs run.
In a tangentially related topic, links were not renderings correctly when starting with just `www.` which caused the metadata pane links to not open correctly. Also, adjusted the REGEX to better catch link-like strings.
laritakr
approved these changes
Mar 30, 2023
|
@laritakr Good call, looks like we didn't need that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #206
Add fixtures and move them to test app
This commit will add rights_statements and licenses to spec fixtures and
adds a rake task to move them into the internal test app so they can be
used for specs.
Add the ability to render questioning authorities
This commit will enable rights_statement and license to render the term
and not the URI.
Only keep the authorities used in the test
It seems unnecessary to have all the authorities. This commit removes
everything except for the ones used in the test.
Adjust GitHub CI steps
Prior to this commit, the jobs:test:setup_db_cmd only ran the
engine_cart:generate command. This commit will add a custom task that
runs generate and copies over the authorities before specs run.