Remove bootstrap gem from gemfile #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After merging and updating locally, you may need to run |
We now use bootstrap 5 via npm with vite, not from the rubygem. The rubygem is unneeded. Remove duplicate sprockets/sprockets-rails in gemfile, only sprockets-rails, higher in gemfile. Having them both with sprockets first was effecting load order in a weird way that prevented startup, in the absence of sassc-rails which had been a bootstrap gem indirect dependency.
jrochkind
force-pushed
the
remove_bootstrap_gem
branch
from
3c58a9a to
1b2b833
Compare
Shuffle around dependencies required when bootstrap's indirect dependencies disappear. We require sprockets-rails directly, and for some reason it requires sassc-rails even though we aren't actually using it. We are at this point not compiling/bundling anything with sprockets, it's all through vite, so removing all non-default sprockets config that doesn't apply anymore too. we should be set up for an easy switch to rails-preferred propshaft in the future, as we are not using sprockets for bundling.
|
approved by eddie verbally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use bootstrap 5 via npm with vite, not from the rubygem. The rubygem is unneeded.
Future versions were having some dependency conflicts and setup changes that we don't need to deal with, as we don't need it!
Shuffle around dependencies required when bootstrap's indirect dependencies disappear. We require sprockets-rails directly, and for some reason it requires sassc-rails even though we aren't actually using it.
We are at this point not compiling/bundling anything with sprockets, it's all through vite, so removing all non-default sprockets config that doesn't apply anymore too.
We should be set up for an easy switch to rails-preferred propshaft in the future, as we are not using sprockets for bundling/compiling, only for what propshaft easily swaps in for. Recorded for future work at #2798