Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: switch all packed fields to big endian (network byte order) #25

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Refactor: switch all packed fields to big endian (network byte order) #25

merged 6 commits into from
Oct 17, 2024

Conversation

antoniaelsen
Copy link
Contributor

@antoniaelsen antoniaelsen commented Oct 15, 2024 •
edited
Loading

  • BE byte order
  • Updated Electrical Broadband channel data packing -- it is tightly packed again
  • Break up Electrical Broadband NDTP packets if they would exceed min MTU (1400ish)

@antoniaelsen antoniaelsen changed the base branch from main to emma-async-signal-chain October 15, 2024 20:42
@antoniaelsen antoniaelsen changed the base branch from emma-async-signal-chain to main October 16, 2024 00:13
@antoniaelsen antoniaelsen requested a review from maxhodak October 16, 2024 05:17
@antoniaelsen antoniaelsen merged commit b6048f9 into main Oct 17, 2024
1 check passed
@antoniaelsen antoniaelsen deleted the refactor/big-endian branch October 17, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmazhou emmazhou emmazhou approved these changes

@chu-k chu-k Awaiting requested review from chu-k

@maxhodak maxhodak Awaiting requested review from maxhodak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoniaelsen @emmazhou