Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify SpikeDetectConfig, remove SpikeDetectOptions #19

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Simplify SpikeDetectConfig, remove SpikeDetectOptions #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
211d9df
simplify SpikeDetectConfig, remove SpikeDetectOptions
emmazhou Sep 24, 2024
72500f9
spacing nit
emmazhou Sep 24, 2024
0669ef2
Merge branch 'main' into emma-spike-detect
emmazhou Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion api/node.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ message NodeOptions {
ElectricalStimOptions electrical_stim = 4;
OpticalBroadbandOptions optical_broadband = 5;
OpticalStimOptions optical_stim = 6;
SpikeDetectOptions spike_detect = 7;
}
}

Expand Down
20 changes: 9 additions & 11 deletions api/nodes/spike_detect.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,18 @@ syntax = "proto3";

package synapse;

message SpikeDetectOptions {
enum SpikeDetectMode {
kThreshold = 0;
kTemplate = 1;
kWavelet = 2;
}
message TemplateMatcher {
repeated uint32 template_uV = 1;
}

repeated SpikeDetectMode mode = 1;
message Thresholder {
uint32 threshold_uV = 1;
}

message SpikeDetectConfig {
SpikeDetectOptions.SpikeDetectMode mode = 1;
uint32 threshold_uV = 2;
repeated uint32 template_uV = 3;
bool sort = 4;
oneof config {
Thresholder thresholder = 1;
TemplateMatcher template_matcher = 2;
}
uint32 bin_size_ms = 5;
}