Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LSB reporting to broadband peripheral options #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

polymerizedsage
Copy link
Contributor

No description provided.

Copy link
Contributor

@maxhodak maxhodak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is a function of configuration, it clearly does not make sense to put in the options message like this. It may be returned in some status / info thing, or maybe as a query.

@polymerizedsage
Copy link
Contributor Author

Given this is a function of configuration, it clearly does not make sense to put in the options message like this. It may be returned in some status / info thing, or maybe as a query.

Perhaps we should rename the Options protos. Currently they are used to report the available configurations of peripherals. Since LSB is a attribute of specific peripheral and not a Node it seems fitting to return information about it in that message. The peripheral options message is returned in info calls about the device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants