Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LT-Global-Background: Added Apple Silicon Support #162

Merged

Conversation

hwoongkang
Copy link
Contributor

Note: Please add new plugins and scripts at the end of the plugins = ( ... ) or scripts = ( ... ) lists.

Since I successfully managed to build and test the product on my apple silicon Mac, I would like to delete the "archs: intel" field from the packages.

Here are some changes I made which I would like to double-check whether it is ok/correct:

  1. Xcode Template suggested to set the build target to 10.11, but when I tried to modify the project the minimum was 10.13. Thus I set the target to 10.13.

  2. I modified the "Run destination" from "My Mac" to "Any Mac (Apple Silicon, Intel)", and archived it to make a release-profiled compilation. It worked on my Apple Silicon Mac, but I couldn't test it on Intel since I don't have one anymore. Will it work on Intel too, or should I change archs to "archs: (arm)"? The compiled plugin is posted here: https://github.com/Leedotype/global-background

anymac

@schriftgestalt
Copy link
Owner

Xcode Template suggested to set the build target to 10.11, but when I tried to modify the project the minimum was 10.13. Thus I set the target to 10.13.

You need Xcode 14.0.1 to build for macOS 10.11. That is the oldest version of macOS that Glyphs still supports. But only very few people still use it. So 10.13 should be enough. But to be sure, add minSystemVersion = "10.13"; to the packages.plist. And I just now added system version keys for the info.plist of the plugin, too (MinSystemVersion, and MaxSystemVersion). So add those to the plugin, too.

	<key>MinSystemVersion</key>
	<string>10.13</string>

@florianpircher
Copy link
Collaborator

The “Run destination” does not affect the archive. Instead, the archive will use the Release configuration, like so:

You can verify this by running the file command in Terminal and point to the executable in your plugin:

$ file LT-Global-Background.glyphsReporter/Contents/MacOS/LT-Global-Background 
LT-Global-Background.glyphsReporter/Contents/MacOS/LT-Global-Background: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit bundle x86_64] [arm64:Mach-O 64-bit bundle arm64]
LT-Global-Background.glyphsReporter/Contents/MacOS/LT-Global-Background (for architecture x86_64):	Mach-O 64-bit bundle x86_64
LT-Global-Background.glyphsReporter/Contents/MacOS/LT-Global-Background (for architecture arm64):	Mach-O 64-bit bundle arm64

@hwoongkang
Copy link
Contributor Author

@florianpircher Thank you! I will use this check from now on.

@schriftgestalt I updated MinSystemVersion = "10.13" in the repository: https://github.com/Leedotype/global-background

@schriftgestalt schriftgestalt merged commit cb1b502 into schriftgestalt:glyphs3 Dec 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants