Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new plugin : Gradient Hatch #142

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

tcarisland
Copy link
Contributor

add new plugin = Gradient Hatch

@florianpircher
Copy link
Collaborator

Hi, thank you for adding this plugin. I cannot get the gradient to work, all lines have the same distance:

Bildschirmfoto 2024-02-14 um 17 07 47

Am I doing something wrong?

@tcarisland
Copy link
Contributor Author

This seems correct, which version of Glyphs are you using?

@tcarisland
Copy link
Contributor Author

Can you see any error messages in the Macro Panel?

@tcarisland
Copy link
Contributor Author

Skjermbilde 2024-02-14 kl  17 11 13

This is the output I get when I try the same values.

@florianpircher
Copy link
Collaborator

I will move this discussion to the issues on your repo:

tcarisland/GradientHatch#39

@tcarisland
Copy link
Contributor Author

  1. Initial bug was caused by locale-specific code, fixed by using layer.ascender and layer.descender in Lines have the same distance tcarisland/GradientHatch#39
  2. The locale issues were fixed by removing automatically translated locale strings, might ask around in the forum for better translations. Created separate issue for layout challenges. Localization tcarisland/GradientHatch#41
  3. A bug was discovered that allowed for negative numbers in the stepWidth. Failsafes and constraints added in Ensure that the step width must be positive tcarisland/GradientHatch#40

@tcarisland
Copy link
Contributor Author

Ready for merge unless something else blocks

@florianpircher florianpircher merged commit 31f925e into schriftgestalt:glyphs3 Feb 15, 2024
1 check passed
@florianpircher
Copy link
Collaborator

Works well, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants