Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter to relations #241

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add filter to relations #241

wants to merge 2 commits into from

Conversation

stivehu
Copy link

@stivehu stivehu commented Aug 16, 2018

Add filter to relations

@uldisn
Copy link
Contributor

uldisn commented Aug 16, 2018 •
edited
Loading

Please add:
->limit(1000)->orderBy([ '{$title}'=>SORT_DESC])

@stivehu
Update RelationProvider.php
2b3238e 
Added limit and sort
@schmunk42
Copy link
Owner

schmunk42 commented Aug 22, 2018 •
edited
Loading

@eluhr @handcode Opinons?

I'd prefer kind of an option to enable this, there'll always be a limit not matching the use-case.

[addon] and tests are failing...

@uldisn
Copy link
Contributor

uldisn commented Aug 22, 2018

I suggest use limit 1000. If no limit and huge table, generated big HTML and browser do not open it. Do not show any info about reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stivehu @uldisn @schmunk42