Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of development/x major version #187

Merged
merged 37 commits into from
Aug 14, 2024

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Jul 30, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 99.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.49%. Comparing base (cc34332) to head (07f5cc9).
Report is 3 commits behind head on main.

Files Patch % Lines
bert_e/workflow/gitwaterflow/branches.py 96.49% 2 Missing ⚠️
bert_e/tests/test_bert_e.py 99.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   87.32%   87.49%   +0.17%     
==========================================
  Files          71       73       +2     
  Lines       10042    10207     +165     
==========================================
+ Hits         8769     8931     +162     
- Misses       1273     1276       +3     
Flag Coverage Δ
integration 87.86% <98.87%> (+0.16%) ⬆️
tests 87.75% <98.87%> (+0.08%) ⬆️
tests-BuildFailedTest ?
tests-QuickTest 33.33% <28.94%> (+0.17%) ⬆️
tests-RepositoryTests 26.24% <7.14%> (-0.27%) ⬇️
tests-TaskQueueTests 51.01% <35.71%> (-0.07%) ⬇️
tests-TestBertE 64.64% <44.73%> (-0.21%) ⬇️
tests-TestQueueing 53.50% <55.63%> (-0.28%) ⬇️
tests-api-mock 64.34% <ø> (ø)
tests-noqueue 77.14% <66.16%> (+0.22%) ⬆️
tests-noqueue-BuildFailedTest 26.43% <7.14%> (-0.28%) ⬇️
tests-noqueue-QuickTest 33.33% <28.94%> (+0.17%) ⬆️
tests-noqueue-RepositoryTests 26.24% <7.14%> (-0.27%) ⬇️
tests-noqueue-TaskQueueTests 51.01% <35.71%> (-0.07%) ⬇️
tests-noqueue-TestBertE 60.95% <43.23%> (-0.10%) ⬇️
tests-noqueue-TestQueueing 26.27% <7.14%> (-0.27%) ⬇️
tests-server 51.30% <28.76%> (-0.16%) ⬇️
unittests 36.39% <14.66%> (-0.24%) ⬇️
utests 2.99% <7.66%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcarmet tcarmet force-pushed the feature/PTFE-1927-dev-major-support branch from 1db5a1e to ab68fcb Compare August 7, 2024 22:16
@tcarmet tcarmet marked this pull request as ready for review August 9, 2024 21:22
@tcarmet tcarmet requested a review from a team as a code owner August 9, 2024 21:22
Copy link
Contributor

@nootal nootal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comment.
Quite impressive the amount of code for supporting this new feature.
Great job!

CHANGELOG Show resolved Hide resolved
bert_e/lib/versions.py Outdated Show resolved Hide resolved
Co-authored-by: Charles Prost - Scality <[email protected]>
@tcarmet tcarmet merged commit 7650262 into main Aug 14, 2024
19 checks passed
@tcarmet tcarmet deleted the feature/PTFE-1927-dev-major-support branch August 14, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants