Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node dependencies and node to 22 #2582

Draft
wants to merge 47 commits into
base: development/9.0
Choose a base branch
from

Conversation

KillianG
Copy link
Contributor

@KillianG KillianG commented Nov 5, 2024

Issue: BB-585

@bert-e
Copy link
Contributor

bert-e commented Nov 5, 2024

Hello killiang,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@KillianG KillianG changed the base branch from development/8.7 to development/8.6 November 5, 2024 12:48
@scality scality deleted a comment from bert-e Nov 5, 2024
@bert-e
Copy link
Contributor

bert-e commented Nov 5, 2024

Incorrect fix version

The Fix Version/s in issue BB-585 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.6.50

  • 8.7.0

Please check the Fix Version/s of BB-585, or the target
branch of this pull request.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.30%. Comparing base (13e845a) to head (9b9db18).

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
bin/backbeat.js 48.14% <ø> (ø)

... and 27 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 57.88% <ø> (-17.60%) ⬇️
Core Library 75.56% <ø> (-0.14%) ⬇️
Ingestion 69.24% <ø> (ø)
Lifecycle 76.16% <ø> (ø)
Oplog Populator 82.85% <ø> (-0.48%) ⬇️
Replication 57.77% <ø> (-0.03%) ⬇️
Bucket Scanner 85.60% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.0    #2582      +/-   ##
===================================================
- Coverage            70.98%   70.30%   -0.68%     
===================================================
  Files                  197      194       -3     
  Lines                13285    12970     -315     
===================================================
- Hits                  9430     9119     -311     
+ Misses                3845     3841       -4     
  Partials                10       10              
Flag Coverage Δ
bucket-scanner 85.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@KillianG KillianG force-pushed the improvement/BB-585-review-and-bumpd-deps branch 2 times, most recently from 4a218a2 to c66992e Compare November 5, 2024 13:57
@bert-e
Copy link
Contributor

bert-e commented Nov 19, 2024

Incorrect fix version

The Fix Version/s in issue BB-585 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.6.52

  • 8.7.0

Please check the Fix Version/s of BB-585, or the target
branch of this pull request.

@KillianG KillianG force-pushed the improvement/BB-585-review-and-bumpd-deps branch 3 times, most recently from 131c31e to 1b741c3 Compare November 19, 2024 11:22
@francoisferrand francoisferrand changed the base branch from development/8.6 to development/9.0 November 20, 2024 10:39
@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2024

Branches have diverged

This pull request's source branch improvement/BB-585-review-and-bumpd-deps has diverged from
development/9.0 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/9.0 into improvement/BB-585-review-and-bumpd-deps
  • Rebase improvement/BB-585-review-and-bumpd-deps onto origin/development/9.0

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

@KillianG KillianG force-pushed the improvement/BB-585-review-and-bumpd-deps branch from a902d82 to 717aba5 Compare November 20, 2024 12:35
@bert-e
Copy link
Contributor

bert-e commented Nov 20, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@bert-e
Copy link
Contributor

bert-e commented Nov 21, 2024

Conflict

There is a conflict between your branch improvement/BB-585-review-and-bumpd-deps and the
destination branch development/9.0.

Please resolve the conflict on the feature branch (improvement/BB-585-review-and-bumpd-deps).

git fetch && \
git checkout origin/improvement/BB-585-review-and-bumpd-deps && \
git merge origin/development/9.0

Resolve merge conflicts and commit

git push origin HEAD:improvement/BB-585-review-and-bumpd-deps

@bert-e
Copy link
Contributor

bert-e commented Nov 21, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants