Fix route delete bug

[williamlardier]

[bert-e]

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue ARSN-448 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.1.142

• 8.2.0

Please check the Fix Version/s of ARSN-448, or the target
branch of this pull request.

[francoisferrand]

Can we add unit tests for these functions?

[williamlardier]

I added some but they don't cover all the paths, I will add it (while I am confirming in cloudserver the fix)

[williamlardier]

(we had 0 unit test for the routes before)

[williamlardier]

Done in 24a87f5

we already have it but it was not testing both cases...

[bert-e]

Incorrect fix version

The Fix Version/s in issue ARSN-448 contains:

• 8.1.142

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 8.1.142

• 8.2.0

Please check the Fix Version/s of ARSN-448, or the target
branch of this pull request.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.27%. Comparing base (e601390) to head (7402f09).
Report is 3 commits behind head on development/8.1.

Additional details and impacted files

@@               Coverage Diff                @@
##           development/8.1    #2273   +/-   ##
================================================
  Coverage            66.27%   66.27%           
================================================
  Files                  215      215           
  Lines                17329    17329           
  Branches              3553     3529   -24     
================================================
  Hits                 11485    11485           
  Misses                5829     5829           
  Partials                15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bert-e]

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

[williamlardier]

/create_integration_branches

[bert-e]

Integration data created

I have created the integration data for the additional destination branches.

• this pull request will merge bugfix/ARSN-448 into
  development/8.1
• w/8.2/bugfix/ARSN-448 will be merged into development/8.2

The following branches will NOT be impacted:

• development/6.4
• development/7.10
• development/7.4
• development/7.70

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

The following options are set: create_integration_branches

[williamlardier]

/approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/8.1

• ✔️ development/8.2

The following branches have NOT changed:

• development/6.4
• development/7.10
• development/7.4
• development/7.70

Please check the status of the associated issue ARSN-448.

Goodbye williamlardier.

The following options are set: approve, create_integration_branches