Memory leak during internal object listing #2264

williamlardier · 2024-10-17T09:25:28Z

Happens when the Skip algorithms tells the function to skip an entry.
In this case, we recursively call the internalListObject function.
However, we never properly close the stream created from the Transform object, that requires specific cleanup.
Overall, the logic is too complex, so cleaning is now centralized and modular, so we clean anything that is still there, in a more clear fashion: we clean any of the three streams. If the stream was already destroyed, the operation is a no-op, but at least, all paths now lead to a consistent cleaning of the resources.

For reference, some tests were started to automate memory leak detection, but not very stable so far, or require to run it for long times: https://github.com/scality/Arsenal/compare/bugfix/ARSN-437-ballooning?expand=1

- Happens when the Skip algorithms tells the function to skip an entry. - In this case, we recursively call the internalListObject function. - However, we never properly close the stream created from the Transform object, that requires specific cleanup. - Overall, the logic is too complex, so cleaning is now centralized and modular, so we clean anything that is still there. Issue: ARSN-437

Issue: ARSN-437

bert-e · 2024-10-17T09:25:33Z

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2024-10-17T09:25:39Z

Incorrect fix version

The Fix Version/s in issue ARSN-437 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

8.1.139

Please check the Fix Version/s of ARSN-437, or the target
branch of this pull request.

lib/storage/metadata/mongoclient/MongoClientInterface.js

bert-e · 2024-10-17T11:54:28Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

To avoid missing code paths where some sockets are not properly cleaned, we now clean each of them when calling cbOnce, to ensure the logic is called once per function (or recursive) call. Issue: BB-602

codecov · 2024-10-17T12:53:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.90%. Comparing base (c993537) to head (94c7038).
Report is 5 commits behind head on development/8.1.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           development/8.1    #2264      +/-   ##
===================================================
+ Coverage            64.84%   64.90%   +0.06%     
===================================================
  Files                  215      215              
  Lines                17287    17298      +11     
  Branches              3535     3514      -21     
===================================================
+ Hits                 11209    11228      +19     
+ Misses                6063     6055       -8     
  Partials                15       15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/storage/metadata/mongoclient/MongoClientInterface.js

A specific case, before calling recursively the function, require a cleanup of the resources. Issue: BB-602

Issue: ARSN-437

bert-e · 2024-10-18T09:42:02Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

williamlardier · 2024-10-18T12:05:22Z

/create_integration_branches

bert-e · 2024-10-18T12:05:31Z

Integration data created

I have created the integration data for the additional destination branches.

this pull request will merge bugfix/ARSN-437 into
development/8.1
w/8.2/bugfix/ARSN-437 will be merged into development/8.2

The following branches will NOT be impacted:

development/6.4
development/7.10
development/7.4
development/7.70

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

bert-e · 2024-10-18T12:05:32Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: create_integration_branches

williamlardier · 2024-10-21T07:54:19Z

/approve

bert-e · 2024-10-21T07:54:33Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/8.1
✔️ development/8.2

The following branches have NOT changed:

development/6.4
development/7.10
development/7.4
development/7.70

Please check the status of the associated issue ARSN-437.

Goodbye williamlardier.

The following options are set: approve, create_integration_branches

williamlardier added 2 commits October 14, 2024 16:56

Add tests to cover a listing path with recursive calls

7889c2f

Issue: ARSN-437

williamlardier requested review from francoisferrand, KillianG, Kerkesni and benzekrimaha October 17, 2024 09:27

francoisferrand reviewed Oct 17, 2024

View reviewed changes

lib/storage/metadata/mongoclient/MongoClientInterface.js Outdated Show resolved Hide resolved

Make the internal listing cleanup logic consistent

d2d5391

To avoid missing code paths where some sockets are not properly cleaned, we now clean each of them when calling cbOnce, to ensure the logic is called once per function (or recursive) call. Issue: BB-602

williamlardier force-pushed the bugfix/ARSN-437 branch from 13b03d1 to 21210d3 Compare October 17, 2024 12:47

williamlardier requested a review from francoisferrand October 17, 2024 12:48

francoisferrand reviewed Oct 17, 2024

View reviewed changes

lib/storage/metadata/mongoclient/MongoClientInterface.js Show resolved Hide resolved

williamlardier force-pushed the bugfix/ARSN-437 branch 2 times, most recently from 143e999 to 8daf4a2 Compare October 17, 2024 14:08

williamlardier added 2 commits October 17, 2024 16:11

Only destroy streams in cbOnce, and "end" from events

8961aa5

A specific case, before calling recursively the function, require a cleanup of the resources. Issue: BB-602

Bump to 8.1.139

94c7038

Issue: ARSN-437

williamlardier force-pushed the bugfix/ARSN-437 branch from 8daf4a2 to 94c7038 Compare October 17, 2024 14:11

williamlardier requested a review from francoisferrand October 17, 2024 14:14

francoisferrand approved these changes Oct 18, 2024

View reviewed changes

scality deleted a comment from bert-e Oct 18, 2024

Kerkesni approved these changes Oct 18, 2024

View reviewed changes

bert-e merged commit 94c7038 into development/8.1 Oct 21, 2024
9 checks passed

bert-e deleted the bugfix/ARSN-437 branch October 21, 2024 07:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Memory leak during internal object listing #2264

Memory leak during internal object listing #2264

williamlardier commented Oct 17, 2024 •

edited

Loading

bert-e commented Oct 17, 2024

bert-e commented Oct 17, 2024

bert-e commented Oct 17, 2024

codecov bot commented Oct 17, 2024 •

edited

Loading

bert-e commented Oct 18, 2024

williamlardier commented Oct 18, 2024

bert-e commented Oct 18, 2024

bert-e commented Oct 18, 2024

williamlardier commented Oct 21, 2024

bert-e commented Oct 21, 2024

Memory leak during internal object listing #2264

Memory leak during internal object listing #2264

Conversation

williamlardier commented Oct 17, 2024 • edited Loading

bert-e commented Oct 17, 2024

Hello williamlardier,

bert-e commented Oct 17, 2024

Incorrect fix version

bert-e commented Oct 17, 2024

Waiting for approval

codecov bot commented Oct 17, 2024 • edited Loading

Codecov Report

bert-e commented Oct 18, 2024

Request integration branches

williamlardier commented Oct 18, 2024

bert-e commented Oct 18, 2024

Integration data created

bert-e commented Oct 18, 2024

Waiting for approval

williamlardier commented Oct 21, 2024

bert-e commented Oct 21, 2024

williamlardier commented Oct 17, 2024 •

edited

Loading

codecov bot commented Oct 17, 2024 •

edited

Loading