Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure getBucketInfos acces only mongo collections #2257

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

francoisferrand
Copy link
Contributor

This is especially needed after PRA bootstrap was executed, as we
started using views in that context.

Issue: ARSN-432

This is especially needed after PRA bootstrap was executed, as we
started using views in that context.

Issue: ARSN-432
@bert-e
Copy link
Contributor

bert-e commented Sep 13, 2024

Hello francoisferrand,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.85%. Comparing base (b5b126a) to head (ca26206).
Report is 2 commits behind head on development/8.1.

Files with missing lines Patch % Lines
...orage/metadata/mongoclient/MongoClientInterface.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/8.1    #2257      +/-   ##
===================================================
+ Coverage            64.75%   64.85%   +0.09%     
===================================================
  Files                  213      213              
  Lines                17156    17156              
  Branches              3492     3515      +23     
===================================================
+ Hits                 11110    11126      +16     
+ Misses                6031     6029       -2     
+ Partials                15        1      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scality scality deleted a comment from bert-e Sep 16, 2024
@bert-e
Copy link
Contributor

bert-e commented Sep 16, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@francoisferrand
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Sep 19, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70

Please check the status of the associated issue ARSN-432.

Goodbye francoisferrand.

The following options are set: approve

@bert-e bert-e merged commit ca26206 into development/8.1 Sep 19, 2024
5 checks passed
@bert-e bert-e deleted the bugfix/ARSN-432 branch September 19, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants