Post reviews fixups

scality · Oct 22, 2024 · cb09de6 · cb09de6
1 parent 751140a
commit cb09de6
Show file tree

Hide file tree

Showing 10 changed files with 8 additions and 11 deletions.
diff --git a/lib/algos/list/delimiter.ts b/lib/algos/list/delimiter.ts
@@ -1,4 +1,4 @@
-'use strict';  
+'use strict';
 
 const Extension = require('./Extension').default;
 const { inc, listingParamsMasterKeysV0ToV1,

diff --git a/lib/models/LifecycleConfiguration.ts b/lib/models/LifecycleConfiguration.ts
@@ -262,7 +262,6 @@ export default class LifecycleConfiguration {
                 break;
             } else {
                 const propName = prop.propName;
-
                 delete prop.propName;
                 if (prop[propName] !== undefined) {
                     ruleObj[propName] = prop[propName];
@@ -675,7 +674,7 @@ export default class LifecycleConfiguration {
             ':([0-5][0-9])' + // Second
             '(\\.[0-9]+)?' + // Fractional second
             '(Z|[+-][01][0-9]:[0-5][0-9])?$', // Timezone
-            'g'
+            'g',
         );
         const matches = [...date.matchAll(isoRegex)];
         if (matches.length !== 1) {

diff --git a/lib/models/ObjectMDAmzRestore.ts b/lib/models/ObjectMDAmzRestore.ts
@@ -32,7 +32,6 @@ export default class ObjectMDAmzRestore {
      */
     static isValid(data: { 'ongoing-request': boolean; 'expiry-date': Date | string }) {
         try {
-
             new ObjectMDAmzRestore(data['ongoing-request'], data['expiry-date']);
             return true;
         } catch {

diff --git a/lib/models/ObjectMDArchive.ts b/lib/models/ObjectMDArchive.ts
@@ -51,7 +51,6 @@ export default class ObjectMDArchive {
         restoreWillExpireAt?: Date;
     }) {
         try {
-
             new ObjectMDArchive(
                 data.archiveInfo,
                 data.restoreRequestedAt,

diff --git a/lib/policyEvaluator/utils/wildcards.ts b/lib/policyEvaluator/utils/wildcards.ts
@@ -30,7 +30,6 @@ export const handleWildcards = (string: string) => {
     // Escape all regExp special characters
     // Then replace the AWS special characters with regExp equivalents
     const regExStr = string.replace(/[\\^$*+?.()|[\]{}]/g, '\\$&').replace(
-
         /(\\\*)|(\\\?)|(\\\$\\\{\\\*\\\})|(\\\$\\\{\\\?\\\})|(\\\$\\\{\\\$\\\})/g,
         characterMap
     );

diff --git a/lib/s3middleware/processMpuParts.ts b/lib/s3middleware/processMpuParts.ts
@@ -86,7 +86,6 @@ export function generateMpuPartStorageInfo(filteredPartList: any[]) {
                 cipheredDataKey: location.sseCipheredDataKey,
             };
             dataLocations.push(pieceRetrievalInfo);
-
             calculatedSize += pieceSize;
         }
     });

diff --git a/lib/s3middleware/userMetadata.ts b/lib/s3middleware/userMetadata.ts
@@ -11,7 +11,9 @@ export function getMetaHeaders(headers: http.IncomingHttpHeaders) {
     const rawHeaders = Object.entries(headers);
     const filtered = rawHeaders.filter(([k]) => k.startsWith('x-amz-meta-'));
     const totalLength = filtered.reduce((length, [k, v]) => {
-        if (!v) {return length;}
+        if (!v) {
+            return length;
+        }
         return length + k.length + v.toString().length;
     }, 0);
     if (totalLength <= constants.maximumMetaHeadersSize) {

diff --git a/lib/versioning/Version.ts b/lib/versioning/Version.ts
@@ -111,7 +111,7 @@ export class Version {
         const needComma = stringifiedObject.charAt(index) !== '{';
         return (
             `${stringifiedObject.slice(0, stringifiedObject.length - 1)}${ 
-                needComma ? ',' : '' 
+                needComma ? ',' : ''
             }"${key}":"${value}"}`
         );
     }

diff --git a/tests/functional/clustering/ClusterRPC.spec.js b/tests/functional/clustering/ClusterRPC.spec.js
@@ -93,7 +93,7 @@ function runTest(testUrl, cb) {
         .on('error', err => cb(err));
 }
 
-describe.only('ClusterRPC', () => {
+describe('ClusterRPC', () => {
     beforeAll(done => startTestServer(done));
     afterAll(done => stopTestServer(done));
 

diff --git a/tests/unit/algos/list/delimiterMaster.spec.ts b/tests/unit/algos/list/delimiterMaster.spec.ts
@@ -1,4 +1,4 @@
-'use strict';  
+'use strict';
 
 const assert = require('assert');