Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tutorial): Add tutorials for Kubernetes Easy Deploy applications #3300

Merged
merged 18 commits into from
Jun 24, 2024

Conversation

bene2k1
Copy link
Member

@bene2k1 bene2k1 commented Jun 11, 2024

Your checklist for this pull request

Description

Please describe what you added or changed.

@bene2k1 bene2k1 added do not merge PR that shouldn't be merged before a specific date (eg release) status: draft Work in progress - do not merge or review labels Jun 11, 2024
@bene2k1 bene2k1 changed the title Mta 4707 feat(tutorial): Add tutorials for Kubernetes Easy Deploy applications Jun 13, 2024
@bene2k1 bene2k1 removed the do not merge PR that shouldn't be merged before a specific date (eg release) label Jun 13, 2024
@bene2k1 bene2k1 self-assigned this Jun 13, 2024
@bene2k1 bene2k1 requested review from RoRoJ and nerda-codes June 13, 2024 09:56
@bene2k1 bene2k1 marked this pull request as ready for review June 13, 2024 09:56
@github-actions github-actions bot removed the status: draft Work in progress - do not merge or review label Jun 13, 2024
@bene2k1 bene2k1 added do not merge PR that shouldn't be merged before a specific date (eg release) status: tech review Waiting for technical review labels Jun 13, 2024
@tgenaitay
Copy link
Member

I think there's a mismatch in the files/content. ArgoCD tutorial speaks about Grafana and vice-versa

@bene2k1
Copy link
Member Author

bene2k1 commented Jun 17, 2024

I think there's a mismatch in the files/content. ArgoCD tutorial speaks about Grafana and vice-versa

Bien vu. It is fixed

@bene2k1 bene2k1 added type: new content New pages or categories status: doc review Waiting for doc team review labels Jun 17, 2024
tutorials/easydeploy-argocd/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-argocd/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-gitlab-server/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-gitlab-server/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-grafana/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-grafana/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-vault/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-vault/index.mdx Outdated Show resolved Hide resolved
Copy link
Member

@tgenaitay tgenaitay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work. All are good. In particular Vault is very well documented!

Should we remind users that, in the case of ArgoCD and Grafana, the YAML configuration can generate additional costs such as Block Storage volumes or Load Balancers?

That's what we do in the UI already.

tutorials/easydeploy-gitlab-runner/index.mdx Show resolved Hide resolved
tutorials/easydeploy-gitlab-server/index.mdx Show resolved Hide resolved
tutorials/easydeploy-grafana/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-grafana/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-vault/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-vault/index.mdx Show resolved Hide resolved
tutorials/easydeploy-vault/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-vault/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-vault/index.mdx Show resolved Hide resolved
tutorials/easydeploy-vault/index.mdx Show resolved Hide resolved
@bene2k1
Copy link
Member Author

bene2k1 commented Jun 21, 2024

Hello @tgenaitay,

All your comments have been applied.

Should we remind users that, in the case of ArgoCD and Grafana, the YAML configuration can generate additional costs such as Block Storage volumes or Load Balancers?

Indeed, I have added a message box to both tutorials.

@bene2k1 bene2k1 removed status: tech review Waiting for technical review do not merge PR that shouldn't be merged before a specific date (eg release) labels Jun 24, 2024
containers/kubernetes/how-to/enable-easy-deploy.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-argocd/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-gitlab-runner/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-gitlab-runner/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-gitlab-server/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-grafana/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-argocd/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-argocd/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-gitlab-runner/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-gitlab-runner/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-gitlab-runner/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-vault/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-vault/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-vault/index.mdx Show resolved Hide resolved
tutorials/easydeploy-vault/index.mdx Outdated Show resolved Hide resolved
tutorials/easydeploy-vault/index.mdx Outdated Show resolved Hide resolved
Co-authored-by: Rowena Jones <[email protected]>
Co-authored-by: nerda-codes <[email protected]>
@bene2k1 bene2k1 removed the status: doc review Waiting for doc team review label Jun 24, 2024
@bene2k1 bene2k1 merged commit 69dba67 into main Jun 24, 2024
2 checks passed
@bene2k1 bene2k1 deleted the MTA-4707 branch June 24, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: new content New pages or categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants