Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all the resources are namespaced #25

Merged
merged 1 commit into from
May 8, 2024
Merged

Make sure all the resources are namespaced #25

merged 1 commit into from
May 8, 2024

Conversation

MathyV
Copy link
Contributor

@MathyV MathyV commented May 8, 2024

Fixes: #24

@Nox-404
Copy link
Contributor

Nox-404 commented May 8, 2024

Hey, thanks for the fix, some of those resources are not namespaced, we could remove the namespace field for those

@MathyV
Copy link
Contributor Author

MathyV commented May 8, 2024 •
edited
Loading

Indeed, it seems I went a bit overboard :-) I removed the namespaces from the ClusterRole, ClusterRoleBinding and APIService

Nox-404
Nox-404 approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@Nox-404 Nox-404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nox-404 Nox-404 merged commit 51afbfd into scaleway:main May 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nox-404 Nox-404 Nox-404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The bundle.yaml file does not contain all required namespaces
2 participants
@MathyV @Nox-404