Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scalardl-auditor] Support Azure Marketplace #278

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kota2and3kan
Copy link
Collaborator

Description

This PR updates the ScalarDL Auditor Helm Chart to support Azure Marketplace.

To list ScalarDL Auditro on the Azure Marketplace, we have to update our helm chart based on the rules of Azure Marketplace. So, I updated ScalarDL Auditor chart as follows:

  • Add global.azure.* in the values.yaml file.
  • Update spec.template.spec.containers[].image in the deployment.yaml file to pull the container image from ACR for Azure Marketplace.
  • Add the azure-extensions-usage-release-identifier label in the deployment.yaml to trace pods and charge license fees by Azure.

You can see what we need to list products on the Azure Marketplace in the following Azure document.

Also, to reduce the maintenance cost (avoid duplicated maintenance), I updated the current helm chart instead of creating the Azure Marketplace dedicated helm chart. To achieve that, I added the following things:

  • Add global.platform in the values.yaml file.
    • I assume this parameter for switching our helm chart based on platforms (to list on each cloud marketplace, partner catalog or something like that) in the future. In other words, this configuration is not related to Azure Marketplace directly.
    • For example, if you set global.platform=azure, ScalarDL Auditor chart use or add the Azure Marketplace dedicated configurations.
    • We need to do the same thing in the Envoy chart (subchart of ScalarDL Auditor chart). So, I decided to add this parameter as Global Values. We can use this global.platform configuration in both ScalarDL Auditor chart (main chart) and Envoy chart (subchart).

Please take a look!

Related issues and/or PRs

Changes made

  • Update charts/scalardl-audit/templates/auditor/deployment.yaml to add the Azure Marketplace dedicated configurations.
  • Update charts/scalardl-audit/values.yaml to add the Azure Marketplace dedicated configurations.
  • charts/scalardl-audit/README.md and charts/scalardl-audit/values.schema.json are updated automatically based on values.yaml.

Checklist

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@kota2and3kan kota2and3kan added improvement scalardl auditor PR for ScalarDL Auditor chart labels Nov 20, 2024
@kota2and3kan kota2and3kan self-assigned this Nov 20, 2024
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link

@jnmt jnmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link

@choplin choplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement scalardl auditor PR for ScalarDL Auditor chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants