[scalardl-auditor] Support Azure Marketplace #278
+74
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the ScalarDL Auditor Helm Chart to support Azure Marketplace.
To list ScalarDL Auditro on the Azure Marketplace, we have to update our helm chart based on the rules of Azure Marketplace. So, I updated ScalarDL Auditor chart as follows:
global.azure.*
in thevalues.yaml
file.spec.template.spec.containers[].image
in thedeployment.yaml
file to pull the container image from ACR for Azure Marketplace.azure-extensions-usage-release-identifier
label in thedeployment.yaml
to trace pods and charge license fees by Azure.You can see what we need to list products on the Azure Marketplace in the following Azure document.
Also, to reduce the maintenance cost (avoid duplicated maintenance), I updated the current helm chart instead of creating the Azure Marketplace dedicated helm chart. To achieve that, I added the following things:
global.platform
in thevalues.yaml
file.global.platform=azure
, ScalarDL Auditor chart use or add the Azure Marketplace dedicated configurations.global.platform
configuration in both ScalarDL Auditor chart (main chart) and Envoy chart (subchart).Please take a look!
Related issues and/or PRs
Changes made
charts/scalardl-audit/templates/auditor/deployment.yaml
to add the Azure Marketplace dedicated configurations.charts/scalardl-audit/values.yaml
to add the Azure Marketplace dedicated configurations.charts/scalardl-audit/README.md
andcharts/scalardl-audit/values.schema.json
are updated automatically based onvalues.yaml
.Checklist
Additional notes (optional)
N/A
Release notes
N/A