Handle all failures in runWithInputStream #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bell-db
force-pushed
the
bell-db/v0.9.7-failure
branch
from
91c0519 to
07ee8a7
Compare
|
Merged in #367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR precedes #367.
During the investigation of #366, while irrelevant to the root cause, two separate issues are found that can cause the program to be stuck.
gen.runorreadInputStreamToByteArrayWithEnv, theFuturethread will fail but the named pipes & protoc are still waiting for the result, causing the entire program to be stuck. This is now fixed in this PR.finallyfailed, because the ordering offsin.close()andFiles.newOutputStream(outputPipe)is crucial. This is now documented in this PR.