Bump Scala.js to 1.14.0

scalapb · Oct 17, 2023 · ba25726 · ba25726
1 parent 2ccf02d
commit ba25726
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
   scope.
 - Add `derives` and `sealed_oneof_derives` to the message options that adds a
   derived clause to generated messages and sealed oneofs.
+- Bump Scala.js to 1.14.0
 
 ## [0.11.13]
 - Added input and output message type for method descriptor (#1503)

diff --git a/e2e/src/test/scala/NoBoxSpec.scala b/e2e/src/test/scala/NoBoxSpec.scala
@@ -21,11 +21,6 @@ class NoBoxSpec extends AnyFlatSpec with Matchers {
     scalaCar.tyre1 must be(Tyre.defaultInstance)
   }
 
-  "Scala message with a no_box field with null value" should "throw exception when being serialized" in {
-    val car = Car(tyre1 = null)
-    a[Exception] shouldBe thrownBy(car.toByteArray)
-  }
-
   "Scala message with a no_box reference" should "generate correct types" in {
     val car = Car()
     car.dontBoxMeDef mustBe (DontBoxMe.defaultInstance)

diff --git a/e2e/src/test/scalajvm/NoBoxWithJavaSpec.scala b/e2e/src/test/scalajvm/NoBoxWithJavaSpec.scala
@@ -21,4 +21,10 @@ class NoBoxWithJavaSpec extends AnyFlatSpec with Matchers {
     val p = Person("", Money(BigDecimal("123.123")))
     Person.fromJavaProto(Person.toJavaProto(p)) must be(p)
   }
+
+  "Scala message with a no_box field with null value" should "throw exception when being serialized" in {
+    val car = Car(tyre1 = null)
+    a[Exception] shouldBe thrownBy(car.toByteArray)
+  }
+
 }
diff --git a/project/plugins.sbt b/project/plugins.sbt
@@ -1,4 +1,4 @@
-val scalaJSVersion = Option(System.getenv("SCALAJS_VERSION")).getOrElse("1.12.0")
+val scalaJSVersion = Option(System.getenv("SCALAJS_VERSION")).getOrElse("1.14.0")
 
 addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.14.10")