Add full name for Option to resolve name conflicts

Fixes #1623
scalapb · Dec 29, 2023 · 26dec8f · 26dec8f
1 parent 688ddae
commit 26dec8f
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/compiler-plugin/src/main/scala/scalapb/compiler/ParseFromGenerator.scala b/compiler-plugin/src/main/scala/scalapb/compiler/ParseFromGenerator.scala
@@ -175,7 +175,7 @@ private[compiler] class ParseFromGenerator(
                 if (!usesBaseTypeInBuilder(field)) toCustomType(field)(newValBase) else newValBase
 
               val updateOp =
-                if (field.supportsPresence) s"__${field.scalaName} = Option($newVal)"
+                if (field.supportsPresence) s"__${field.scalaName} = _root_.scala.Option($newVal)"
                 else if (field.isInOneof) {
                   s"__${field.getContainingOneof.scalaName.name} = ${field.oneOfTypeName.fullName}($newVal)"
                 } else if (field.isRepeated) s"__${field.scalaName} += $newVal"

diff --git a/compiler-plugin/src/main/scala/scalapb/compiler/ProtobufGenerator.scala b/compiler-plugin/src/main/scala/scalapb/compiler/ProtobufGenerator.scala
@@ -968,7 +968,7 @@ class ProtobufGenerator(
               .add(
                 s"""def $fieldName: ${lensType(
                     field.singleScalaTypeName
-                  )} = field(_.${field.getMethod})((c_, f_) => c_.copy($fieldName = Option(f_)))
+                  )} = field(_.${field.getMethod})((c_, f_) => c_.copy($fieldName = _root_.scala.Option(f_)))
                    |def ${optionLensName}: ${lensType(
                     field.scalaTypeName
                   )} = field(_.$fieldName)((c_, f_) => c_.copy($fieldName = f_))""".stripMargin

diff --git a/e2e/src/main/protobuf/issue1623.proto b/e2e/src/main/protobuf/issue1623.proto
@@ -0,0 +1,18 @@
+syntax = "proto3";
+
+package com.thesamet.proto.e2e.issue1623;
+
+message CreditCard {};
+
+message PayPal {};
+
+message Money {}
+
+message PaymentMethod {
+    string id = 1;
+    Money money = 2;
+    oneof option {
+        CreditCard credit_card = 3;
+        PayPal paypal = 4;
+    }
+}