Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bloop 1.4.1 install #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Bloop 1.4.1 install #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions bloop.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,11 @@
"url": "https://github.com/scalacenter/bloop/releases/download/v1.4.1/bloop-coursier.json",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"url": "https://github.com/scalacenter/bloop/releases/download/v1.4.1/bloop-coursier.json",
"url": "https://github.com/scalacenter/bloop/releases/download/v1.4.8/bloop-coursier.json",

"hash": "sha256:2e6a873183e5e22712913bfdab1331d0a7792167c369fee5be0c83e27572fe12",
"depends": "coursier",
"bin": "bloop",
"env_add_path": "$dir",
"bin": "bloop.bat",
"env_set": {
"BLOOP_HOME": "$dir",
"BLOOP_IN_SCOOP": "true"
"BLOOP_HOME": "$dir"
},
"installer": {
"script": "coursier install --install-dir $dir --default-channels=false --channel $dir bloop"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of keeping these arguments to use the channel bloop-coursier.json? This is the channel we distribute in our release process and we use it in brew as well.

"script": "coursier install --install-dir $dir bloop"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add --prefer-prebuilt true here to avoid coursier trying to compile the application to GraalVM native?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried installing bloop with scoop using this version of line 11. It appears to install properly but can someone double-check?

    "script": "coursier install --install-dir $dir --default-channels=false --channel io.get-coursier:apps bloop"

I'm still learning, but my (fuzzy) understanding is io.get-coursier:apps (ref: coursier docs) is a "Maven coordinate" and it redirects to bloop's most recent jar. Does that sound right?

}
}