Update mdoc to 2.6.2 & metaconfig to 0.14.0 #2144
Merged
+53
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![scala-center-steward[bot]](https://avatars.githubusercontent.com/in/231409?s=60&v=4){kind=small}
bjaglin
reviewed
Dec 18, 2024
| case Some(value) => ev.read(value) | ||
| case None => ConfError.missingField(conf, path).notOk | ||
| } | ||
| ConfGet.getOrElse( |
bjaglin
reviewed
Dec 18, 2024
| @@ -17,7 +17,7 @@ object Dependencies { | |||
| val commontTextV = "1.12.0" | |||
| val googleDiffV = "1.3.0" | |||
| val jgitV = "5.13.3.202401111512-r" | |||
| val metaconfigV = "0.13.0" | |||
| val metaconfigV = "0.14.0" | |||
There was a problem hiding this comment.
bumping this at the same time as doc to prevent
[error] * org.scalameta:metaconfig-typesafe-config_2.13:0.14.0 (early-semver) is selected over {0.13.0}
[error] +- org.scalameta:mdoc_2.13:2.6.2 (depends on 0.14.0)
[error] +- org.scalameta:mdoc-cli_2.13:2.6.2 (depends on 0.14.0)
[error] +- org.scalameta:metaconfig-docs_2.13:0.13.0 (depends on 0.13.0)
[error] +- ch.epfl.scala:scalafix-core_2.13:0.0.0+1-804f3a2e-SNAPSHOT (depends on 0.13.0)
bjaglin
changed the title
|
|
Och, that was my change in scalameta/metaconfig@737be1e Why do we need to publish metaconfig-docs? I thought it's only for the website. |
|
I can't see any usage of metaconfig-docs, maybe we can just remove it? |
|
Looks like we used metaconfig-docs to get |
|
Good catch @tgodzik, thanks! I will remove metaconfig-docs |
bjaglin
force-pushed
the
update/mdoc-2.6.2
branch
from
e9cb330 to
0070476
Compare
bjaglin
reviewed
Dec 21, 2024
| @@ -448,7 +448,7 @@ lazy val docs = projectMatrix | |||
| scalacOptions += "-Wconf:msg='match may not be exhaustive':s", // silence exhaustive pattern matching warning for documentation | |||
| scalacOptions += "-Xfatal-warnings", | |||
| mdoc := (Compile / run).evaluated, | |||
| libraryDependencies += metaconfigDoc, | |||
There was a problem hiding this comment.
bjaglin
force-pushed
the
update/mdoc-2.6.2
branch
2 times, most recently
from
4f1ada4 to
9ee43c6
Compare
bjaglin
force-pushed
the
update/mdoc-2.6.2
branch
from
9ee43c6 to
7166586
Compare
bjaglin
reviewed
Dec 21, 2024
Comment on lines
-244
to
-247
| // https://github.com/scalacenter/scalafix/pull/2025#issuecomment-2264188708 | ||
| "com.geirsson" %% "metaconfig-core", | ||
| "com.geirsson" %% "metaconfig-pprint", | ||
| "com.geirsson" %% "metaconfig-typesafe-config" |
There was a problem hiding this comment.
this was dead conf since the org rename
bjaglin
reviewed
Dec 21, 2024
Comment on lines
+251
to
+257
| // metaconfig has no breaking change from 0.13.0 to 0.14.0 | ||
| "org.scalameta" % "metaconfig-core_2.12" % VersionScheme.Always, | ||
| "org.scalameta" % "metaconfig-core_2.13" % VersionScheme.Always, | ||
| "org.scalameta" % "metaconfig-pprint_2.12" % VersionScheme.Always, | ||
| "org.scalameta" % "metaconfig-pprint_2.13" % VersionScheme.Always, | ||
| "org.scalameta" % "metaconfig-typesafe-config_2.12" % VersionScheme.Always, | ||
| "org.scalameta" % "metaconfig-typesafe-config_2.13" % VersionScheme.Always |
There was a problem hiding this comment.
explicit binary suffix is required because libraryDependencySchemes does not honor for3Use2_13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
📦 Updates
from
2.6.1to2.6.2📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: