Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test JDK23 #2075

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test JDK23 #2075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
fail-fast: false
matrix:
os: ["ubuntu"]
jvm: ["8", "11", "17", "21", "22"]
jvm: ["8", "11", "17", "21", "23"]
include:
- os: windows
jvm: 21
Expand Down
6 changes: 5 additions & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,11 @@ lazy val rules = projectMatrix
semanticdbScalacCore,
collectionCompat
)
else Nil
else
Seq(
// force usage of the latest scala2 library to get compatibility with latest JDK
"org.scala-lang" % "scala-library" % scala213
Comment on lines +124 to +125
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this does not seem to have an impact (at least not on downstream test projects)

)
},
// companion of `.dependsOn(core)`
// issue reported in https://github.com/sbt/sbt/issues/7405
Expand Down
4 changes: 2 additions & 2 deletions project/ScalafixBuild.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ object ScalafixBuild extends AutoPlugin with GhpagesKeys {
previousPatchVersions
.map { patch => s"$binaryVersion.$patch" }
.filterNot { v =>
System.getProperty("java.version").startsWith("22") &&
Seq("2.12.18").contains(v)
System.getProperty("java.version").startsWith("23") &&
Seq("2.12.18", "2.12.19", "2.13.13", "2.13.14").contains(v)
}
}

Expand Down
Loading