Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to only add explicit result types to implicit definitions #1623

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Add an option to only add explicit result types to implicit definitions #1623

merged 1 commit into from
Jul 4, 2022

Conversation

OlegYch
Copy link
Contributor

@OlegYch OlegYch commented Jun 24, 2022

This is useful for scala3 migration since it requires explicit return types for implicits

@bjaglin
Copy link
Collaborator

bjaglin commented Jun 24, 2022

Related to scalacenter/scala3-migrate#334

@bjaglin
Copy link
Collaborator

bjaglin commented Jun 24, 2022

Thanks for the PR, new configuration flag LGTM 👍

Your test seems to be specific to 2.13, I guess you can have a simpler one that compiles also on 2.11 & 2.12?

@OlegYch
Copy link
Contributor Author

OlegYch commented Jun 27, 2022

@bjaglin should work now

bjaglin
bjaglin approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@bjaglin bjaglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bjaglin bjaglin merged commit 638cba2 into scalacenter:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlachkar mlachkar mlachkar approved these changes

@bjaglin bjaglin bjaglin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlegYch @bjaglin @mlachkar