align environment variable name with docusaurus instructions #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danicheg
reviewed
Jan 8, 2024
| @@ -15,4 +15,4 @@ jobs: | |||
| - name: Publish ${{ github.ref }} | |||
| run: sbt docs/docusaurusPublishGhpages | |||
| env: | |||
| GITHUB_DEPLOY_KEY: ${{ secrets.GITHUB_DEPLOY_KEY }} | |||
| GIT_DEPLOY_KEY: ${{ secrets.GIT_DEPLOY_KEY }} | |||
There was a problem hiding this comment.
I think it's no matter how we define the env var in secrets, but I thought it should be GITHUB_DEPLOY_KEY in CI as done in Scalafix, for example https://github.com/scalacenter/scalafix/blob/main/.github/workflows/deploy-website.yml#L17
There was a problem hiding this comment.
Yeah, I'm pretty confident it should be GITHUB_DEPLOY_KEY in CI https://github.com/search?q=org%3Ascalacenter%20GITHUB_DEPLOY_KEY&type=code
There was a problem hiding this comment.
Perhaps the mdoc website is a little bit outdated 🤷🏻
There was a problem hiding this comment.
can't think why it would matter what it's called as long as we're consistent 🤷
danicheg
added
the
docs
|
yay, it's alive https://scalacenter.github.io/scalac-profiling/ |
|
yay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.