Skip to content

Commit

Permalink
Merge pull request #511 from ashawley/mima-signature-checks
Browse files Browse the repository at this point in the history
  • Loading branch information
SethTisue authored May 13, 2021
2 parents 5ffdbc9 + 43e9414 commit 55f9955
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ lazy val xml = crossProject(JSPlatform, JVMPlatform, NativePlatform)
case Some((3, _)) => None
case _ => Some("2.0.0-RC1")
}),
mimaReportSignatureProblems := true,
mimaBinaryIssueFilters ++= {
import com.typesafe.tools.mima.core._
import com.typesafe.tools.mima.core.ProblemFilters._
Expand All @@ -72,8 +73,6 @@ lazy val xml = crossProject(JSPlatform, JVMPlatform, NativePlatform)
// because we reverted #279
exclude[DirectMissingMethodProblem]("scala.xml.Utility.escapeText"),
exclude[MissingClassProblem]("scala.xml.Properties*"),
// New MiMa checks for generic signature changes
exclude[IncompatibleSignatureProblem]("*"),
// afaict this is just a JDK 8 vs 16 difference, producing a false positive when
// we compare classes built on JDK 16 (which we only do on CI, not at release time)
// to previous-version artifacts that were built on 8. see scala/scala-xml#501
Expand Down

0 comments on commit 55f9955

Please sign in to comment.