-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala 2.13.16 release notes (DRAFT) #892
base: scala-dev
Are you sure you want to change the base?
Conversation
2.13.16.md
Outdated
* Deprecate `collection.mutable.AnyRefMap` ([#10862](https://github.com/scala/scala/pull/10862) by [@wangyum](https://github.com/wangyum)) | ||
* It no longer has any performance advantage over `collection.mutable.HashMap` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"no longer" ... since when?
What is the recommendation for cross-compiling code, where Scala 2.12 performance still matters? (in my case, a lot, since it's linker code loaded through an sbt plugin)
Should we move to HashMap
anyway, or should we ignore the deprecation with a compiler flag instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since 2.13.0, as per https://github.com/scala/scala/releases/tag/v2.13.0 — I've pushed an edit to say so
for cross-compiling, I would suggest suppressing the deprecation warning, yes. (I mean if you really wanted you could use version-specific sources...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For those interested, here is the config we used to ignore those in bulk:
scalacOptions ++=
if (scalaVersion.value.startsWith("2.12.")) Nil
else Seq("-Wconf:cat=deprecation&origin=scala\\.collection\\.mutable\\.AnyRefMap.*:s")
feedback welcome