Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Warning options to the list of scala3 compiler options #2959

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rssh
Copy link

@rssh rssh commented Jan 30, 2024

No description provided.

@rssh
Copy link
Author

rssh commented Jan 30, 2024

Occasionally, this will address #2940

@SethTisue SethTisue requested a review from szymon-rd February 13, 2024 23:52

| 3.3.x | description |
|-|-|
| `-Wunused:imports` | Warn about unused imports |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weren't all -Wunused present in Scala 2? The same for value-discard.Wnonunit-statement seems to be new, same for Wimplausible-patterns and some others.

ScalaSettings.scala#L169-L170
https://docs.scala-lang.org/overviews/compiler-options/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scala 2 has -Wnonunit-statement

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, deleted options that were presented in scala-2

By the way, we need another page with all scala3 options in some other document, but this would be another issue.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But -Wnounit-statement for scala2 is not documented in https://docs.scala-lang.org/overviews/compiler-options/

Copy link
Member

@SethTisue SethTisue Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That page has long been in a grievous state of unmaintainedness, I'm ashamed to say: #1711

rssh added 2 commits March 11, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants