Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error on Scala 3.3.1 #2958

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix syntax error on Scala 3.3.1 #2958

merged 1 commit into from
Jan 30, 2024

Conversation

Dieken
Copy link
Contributor

@Dieken Dieken commented Jan 27, 2024

No description provided.

@Philippus
Copy link
Member

Philippus commented Jan 28, 2024

Maybe also changed it here in one go:

<br>val hulk = new DavidBanner with Big,

@Dieken Dieken force-pushed the patch-1 branch 2 times, most recently from 916c1d5 to d2d7b25 Compare January 29, 2024 14:08
@Dieken
Copy link
Contributor Author

Dieken commented Jan 29, 2024

Pushed again, thanks for your reminder!

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is valid syntax in Scala 3

@Philippus
Copy link
Member

I get:

Welcome to Scala 3.3.1 (17.0.10, Java OpenJDK 64-Bit Server VM).
Type in expressions for evaluation. Or try :help.
>....                                                                                                                                                                       | 
     | trait Green:
     |   println("I’m green")
     | 
     | // mix in the traits as DavidBanner
     | // is created
     | val hulk = new DavidBanner with Big, Angry, Green
-- Error: ----------------------------------------------------------------------
15 |val hulk = new DavidBanner with Big, Angry, Green
   |                                   ^
   |                                 end of statement expected but ',' found

@bishabosha
Copy link
Member

oh right, sorry about that I didn't notice it was an anonymous class instance!

@bishabosha bishabosha merged commit 4a14348 into scala:main Jan 30, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants