Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description for dynamic-side-menu scaladoc option #2942

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

Florian3k
Copy link
Contributor

Related dotty PR: scala/scala3#19337

@SethTisue
Copy link
Member

Is this ready for review, perchance?

@Florian3k Florian3k marked this pull request as ready for review February 16, 2024 11:17
@Florian3k
Copy link
Contributor Author

It is, but I wanted to wait with merging until 3.4.1 release (first version with this feature available)

@SethTisue SethTisue marked this pull request as draft March 11, 2024 15:37
@Florian3k Florian3k marked this pull request as ready for review March 29, 2024 12:33
@Florian3k
Copy link
Contributor Author

Looks like I don't have permissions to request a review, @SethTisue could you review this?

@Kordyjan Kordyjan requested a review from SethTisue March 29, 2024 12:39
@SethTisue SethTisue merged commit 31e3aac into scala:main Mar 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants