Implemented metric index reading from annotation #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from: namespace | ||
| - key: splunk.com/metricsIndex | ||
| tag_name: com.splunk.index | ||
| from: pod |
There was a problem hiding this comment.
It would be great if we can also add sourcetype extraction like https://github.com/signalfx/splunk-otel-collector-chart/blob/main/helm-charts/splunk-otel-collector/templates/config/_common.tpl#L117-L118 for metrics.
|
it looks good ! |
sbylica-splunk
commented
Nov 29, 2023
| @@ -163,6 +164,8 @@ processors: | |||
| - action: insert | |||
| key: receiver | |||
| value: k8scluster | |||
| - action: delete | |||
| key: k8s.pod.start_time | |||
There was a problem hiding this comment.
This one I'm not sure about. It's needed to make tests work correctly, but line 523 in functional_test.go should already fix that, so there is something weird going on somewhere. @VihasMakwana
sbylica-splunk
force-pushed
the
metrics_index_from_annotations
branch
from
f8fdd94 to
960caa4
Compare
sbylica-splunk
force-pushed
the
metrics_index_from_annotations
branch
2 times, most recently
from
a243117 to
5979b0c
Compare
sbylica-splunk
force-pushed
the
metrics_index_from_annotations
branch
2 times, most recently
from
ad33c26 to
c30e41d
Compare
sbylica-splunk
force-pushed
the
metrics_index_from_annotations
branch
from
5d798f5 to
089710d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Metrics annotations for metrics index