Merge pull request #354 from sbtqa/fix-pagesource-attach

add try catch to page source get
sbtqa · Oct 13, 2021 · e7454b5 · e7454b5
2 parents 030874f + 49de00d
commit e7454b5
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/...actory-core/src/main/java/ru/sbtqa/tag/pagefactory/aspects/report/ErrorHandlerAspect.java b/...actory-core/src/main/java/ru/sbtqa/tag/pagefactory/aspects/report/ErrorHandlerAspect.java
@@ -8,6 +8,9 @@
 import org.aspectj.lang.annotation.Around;
 import org.aspectj.lang.annotation.Aspect;
 import org.aspectj.lang.annotation.Pointcut;
+import org.openqa.selenium.InvalidElementStateException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import ru.sbtqa.tag.pagefactory.allure.ErrorHandler;
 import ru.sbtqa.tag.pagefactory.allure.ParamsHelper;
 import ru.sbtqa.tag.pagefactory.allure.Type;
@@ -17,6 +20,7 @@
 @Aspect
 public class ErrorHandlerAspect {
 
+    private static final Logger LOG = LoggerFactory.getLogger(ErrorHandlerAspect.class);
     private static final Configuration PROPERTIES = Configuration.create();
 
     private final ThreadLocal<String> stepText = ThreadLocal.withInitial(() -> "");
@@ -35,10 +39,13 @@ public void sendStepFinished(ProceedingJoinPoint joinPoint, Event event) throws
                 && !stepText.get().equals(Allure.getLifecycle().getCurrentTestCaseOrStep().toString())) {
             stepText.set(Allure.getLifecycle().getCurrentTestCaseOrStep().toString());
             ErrorHandler.attachError(testStepFinished.result.getError());
-            System.out.println("    " + testStepFinished.result.getError());
             ErrorHandler.attachScreenshot();
             if (PROPERTIES.isReportXmlAttachEnabled()) {
-                ParamsHelper.addAttachmentToRender(Environment.getDriverService().getDriver().getPageSource().getBytes(), "Page source", Type.XML);
+                try {
+                    ParamsHelper.addAttachmentToRender(Environment.getDriverService().getDriver().getPageSource().getBytes(), "Page source", Type.XML);
+                } catch (InvalidElementStateException e) {
+                    LOG.error("Can't attach page source", e);
+                }
             }
         }
         joinPoint.proceed();