-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 'update' instead of ivy resolution #143
base: main
Are you sure you want to change the base?
Conversation
Thanks for doing the merge, great to see CI indeed succeeding now! This probably means that, after this change, sbt-license-report only works correctly when the project is also using sbt 1.10.5 or later. We should probably document that. Do you think we should also put in a technical safeguard? I'd say documenting it is probably sufficient. |
fixes #87 |
I guess it's it's also possible to check sbt's version and use the old implementation if sbt is not new enough. I'm not so sure it's worth it however. But I think we need at least a warning / error if the sbt version is too old. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for adding that! AFAICS this should now be good to go.
Follow-up to #123 by @raboof, sbt has been updated to 1.10.5 so this shouldn't be blocked anymore.