Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filtering of licenseConfigurations #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ybasket
Copy link
Contributor

@ybasket ybasket commented Nov 5, 2024

With the changes of #86, the filtering of configurations broke and test dependencies got reported even though licenseConfigurations was set to Set("compile"). This seems due to the fact that the resolved Ivy deps do not properly mirror the configurations the dependency was defined for. By selecting the configurations from the report early on, we restore the filtering.

FYI @mdedetrich

With the changes of sbt#86, the filtering of configurations broke and test dependencies got reported even though licenseConfigurations was set to Set("compile"). This is due to the fact that the resolved Ivy deps not properly mirror the configurations the dependency was defined for. By selecting the configurations from the report early on, we restore the filtering.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant