Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing nightlies #407

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fixing nightlies #407

merged 1 commit into from
Oct 10, 2024

Conversation

fbergmann
Copy link
Member

Description

While the previous PR removed attempting to install the non-existing packages. It still had the flags for building R and .NET bindings set to true

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

@fbergmann fbergmann requested a review from skeating October 9, 2024 13:26
@skeating skeating merged commit 5b0cd4b into development Oct 10, 2024
35 checks passed
@skeating skeating deleted the nightly-2 branch October 10, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeating skeating skeating approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbergmann @skeating